Skip to content

[CLIENT-2417] Replace partitions status dictionary with aerospike.PartitionsStatus class#683

Draft
juliannguyen4 wants to merge 72 commits intodevfrom
CLIENT-2417-rm-parts-setup
Draft

[CLIENT-2417] Replace partitions status dictionary with aerospike.PartitionsStatus class#683
juliannguyen4 wants to merge 72 commits intodevfrom
CLIENT-2417-rm-parts-setup

Conversation

@juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Oct 15, 2024

…n python

  • All the test cases in the test file test_scan_get_partitions_status.py are still in test_query_get_partitions_status.py, I believe
  • Valgrind memory leaks for get_partitions_status are gone

TODO: make PartitionsStatus class fully backwards compatible with dictionary class

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.68%. Comparing base (30ee2c9) to head (2eb9d2b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/convert_partition_filter.c 44.44% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #683      +/-   ##
==========================================
- Coverage   81.88%   81.68%   -0.21%     
==========================================
  Files          99       99              
  Lines       14646    14502     -144     
==========================================
- Hits        11993    11846     -147     
- Misses       2653     2656       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliannguyen4 juliannguyen4 changed the title [CLIENT-2417] Only set as_partition_filter.as_partitions_status to a non-NULL value when set by the user in Python [CLIENT-2417] Replace partitions status dictionary with aerospike.PartitionsStatus and aerospike.PartitionStatus classes Nov 18, 2024
@juliannguyen4 juliannguyen4 changed the title [CLIENT-2417] Replace partitions status dictionary with aerospike.PartitionsStatus and aerospike.PartitionStatus classes [CLIENT-2417] Replace partitions status dictionary with aerospike.PartitionsStatus class Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants